gsainfoteam / ziggle-flutter

지스트의 모든 공지를 한눈에
https://ziggle.gistory.me
11 stars 7 forks source link

chore: remove internal library import of flutter_quill #498

Closed 2paperstar closed 2 weeks ago

2paperstar commented 2 weeks ago

close #497

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago
📝 Walkthrough ## Walkthrough 이 변경 사항은 `LinkDialog` 위젯에서 링크 유효성 검사를 위한 새로운 정규 표현식 `_oneLineLinkRegExp`를 도입합니다. 이 정규 표현식은 입력 문자열이 유효한 URL 형식인지 확인하며, 포트 번호와 쿼리 매개변수를 선택적으로 허용합니다. 기존의 유효성 검사 로직은 제거되었으며, 다이얼로그 액션 버튼 활성화 조건이 새로운 정규 표현식을 직접 참조하도록 변경되었습니다. 또한, 더 이상 필요하지 않은 `flutter_quill/extensions.dart`의 import 문이 삭제되었습니다. ## Changes | 파일 경로 | 변경 요약 | |-------------------------------------------|--------------------------------------------| | lib/app/modules/notices/presentation/widgets/link_dialog.dart | 새로운 정규 표현식 `_oneLineLinkRegExp` 추가 및 기존 유효성 검사 로직 제거, import 문 삭제 | ## Possibly related PRs - **#410**: `NoticeRenderer` 클래스의 렌더링 로직 수정, `LinkDialog` 위젯의 링크 유효성 검사 변경과 관련이 있을 수 있음. - **#440**: `NoticeRenderer` 위젯의 추가 콘텐츠 표시 개선, 링크 유효성 검사 변경과 함께 공지 표시와 관련이 있을 수 있음. - **#462**: `NoticeBody` 위젯 변경, 링크가 포함된 공지 렌더링과 관련이 있을 수 있음. - **#475**: `InfiniteScroll` 위젯 리팩토링, 공지 표시와 스크롤 형식 관련, `LinkDialog`의 링크 유효성 검사와 상호작용할 수 있음. - **#496**: `NoticeWriteShellLayout` 변경, 다이얼로그 상호작용과 링크 유효성 검사 과정과 관련이 있을 수 있음. ## Suggested reviewers - dawnfire05 > 🐇 링크 검증 새로워, > 정규 표현식으로 한층 더! > 필요 없는 임포트도 지우고, > 다이얼로그가 더 깔끔해졌네! > URL 체크는 이제 문제 없고, > 공지와 함께 잘 어울리네! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
2paperstar commented 2 weeks ago

@coderabbitai review

coderabbitai[bot] commented 2 weeks ago
:white_check_mark: Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.