gsantner / markor

Text editor - Notes & ToDo (for Android) - Markdown, todo.txt, plaintext, math, ..
https://github.com/gsantner/markor/discussions/2269
Other
3.82k stars 365 forks source link

layout error in mixed unsorted lists with #1643

Closed habibis closed 2 years ago

habibis commented 2 years ago

⚠️ This issue respects the following points: ⚠️

Description

When creating a nested unsorted list in Markdown with combined checkboxes, the layout of the 3. Hierarchy (list, not checkbox) is false. The bullet point appears on top of the text, i.e. too far to the right.

Screenshot_20220319-114324_Markor

Steps to reproduce

  1. Create bullet point list
  2. create checkbox in the following line, indent with 2 spaces
  3. Create bullet point in the following line, indent with 4 spaces in total

Information

Android version: 10 Device: Samsung SM-G960F App Version: v2.8.0

Source

F-Droid

Format / File type

Markdown

Additional info / Log

-
fgtham commented 2 years ago

Why is this closed? I can reproduce it, a simple fix is:

li.task-list-item > ul > li { text-indent: 0pt; }
gsantner commented 2 years ago

It mostly just wastes my and reporters time by making bad bug reports. As you can see in recent issues, theres like 3-4 times the same report about AppIntro library. I rather spend time on improving & fixing then telling the same thing to people, just because they are not able to do a simple search. Even if there is a link, even when I explicitley ask them to do it. And they need to explicitly confirm they have searched.

Bug reports should be tested with latest version, not with old version. At bug report people have to check that. I close issues when I notice they didn't do it. And this is the case here.

Screenshot_20220322-151232 Screenshot_20220322-151238

for the real issue - might be that there is this issue still. But I want to encourage users to give us developers information properly, rather than reporting things many times, or outdated information.


required fix seems easy yeah, thought it's maybe already done at https://github.com/gsantner/markor/pull/1620. so thats especially why I say - it needs to be tested with latest version. In this case it's similar, but requires additional change.