gsantner / markor

Text editor - Notes & ToDo (for Android) - Markdown, todo.txt, plaintext, math, ..
https://github.com/gsantner/markor/discussions/2269
Other
3.7k stars 360 forks source link

Filebrowser: Display filepath at description #1971

Open brunetton opened 1 year ago

brunetton commented 1 year ago

⚠️ This issue respects the following points: ⚠️

Description

I use recently opened files sometimes, but I've some files that have the same name (example: servers.md) but in different folders (typically one folder per client).

In recent files list the full path is not displayed, so it's impossible to distinguish between my 10 servers.md files.

Information

Android version: 12 Device: Huawei P30 Lite / MAR-LX1A App Version: 2.10.7

Source

F-Droid

Format / File type

Not specific

Additional info / Log

I wasn't able to test the dev version as it crashes as soon as I launch it :(

gsantner commented 1 year ago

Special token can be added to the file description formatting settings option. This allows showing the filepath in the second line of text. For recents or more generally anything, I want not to add any special handling - this format is applied everywhere at filebrowser.

Please feel free to contribute to Markor, this is likely very easy to implement and is like 5 lines of code.

brunetton commented 1 year ago

Special token can be added to the file description formatting settings option. This allows showing the filepath in the second line of text

As far as I can see, the file description formatting settings option uses SimpleDateFormat, "with the addition of FS for showing file size".

I don't see how to show "the filepath in the second line of text" using this format. I probably missed something.

Please feel free to contribute to Markor, this is likely very easy to implement and is like 5 lines of code.

Yes indeed; I've already "kind of contributed" here. I'm not a Java dev but I think I could manage to add this; but I wanted to check first if you'd open to this changes.

The question is: do I hardcode it ? ie: adding relative path behind each filename ? Or do I implement the ability to add the filepath in the file description formatting ? (I probably won't do that)

Thanks !

gsantner commented 1 year ago

@brunetton
There is a method to format the description line. There this can be added with a different token, like for example DIRECTORY

grafik

Yes indeed; I've already "kind of contributed". I'm not a Java dev but I think I could manage to add this; but I wanted to check first if you'd open to this changes.

Great to hear, contribution are much appreciated!