Asciidoc :icons implementation

Pyblo commented 7 months ago

⚠️ This issue respects the following points: ⚠️

[X] This is a enhancement/feature request. Not a bug or question.
[X] The topic is not already reported at Issues. (I've searched it).
[X] Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
[X] The wanted feature/enhancement is not present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor's settings are not touched. If your desired feature is present, you don't need to open this issue. The change will be part of the next Markor update.)

Description

I would like for implementation of asciidoc icons icon:heart[role=red]. That would help greatly, since icons can be colored and have many great inline formating features.

It would great if the :icons: font mode worked, but having at least the :icons: svg + :iconsdir: ./icons mode worked.

Information

Android version: 11 Device: xiaomi Mi 10 lite 5g App Version: v2.11.1(148)

Source

F-Droid

Format / File type

Something else (-> Additional info)

Additional info / Log

- it is for Asciidoc format 
- currently we can use the svg image:{icon_name} as a workaround, but it lacks colouring and using it inline is not straightforward.

Pyblo commented 7 months ago

While testing all the other icon implementation on with Asciidoctor, i noticed, that The only way to go is using :icons: font. Unfortunately all other modes display icons that are not properly sized to the text size in lines.

gsantner commented 7 months ago

Please feel free to work on it and create a merge request to make the improvements available to others.

gsantner commented 3 months ago

notice: @aisbergde implemented most of asciidoc support, so assume have an good idea about this too.

aisbergde commented 3 months ago

I only implemented the formatting support in the editor mode (plain text). The preview was implemented by someone else. Is the request related to the preview or to the formatting while editing?

gsantner / markor