gsantner / markor

Text editor - Notes & ToDo (for Android) - Markdown, todo.txt, plaintext, math, ..
https://github.com/gsantner/markor/discussions/2269
Other
3.57k stars 357 forks source link

FileBrowser: File Modification Time not updated until app restart #2196

Open XYIheng opened 6 months ago

XYIheng commented 6 months ago

⚠️ This issue respects the following points: ⚠️

Description

Modifying a file does not update its modification time immediately. Refresh file list also not work.
The file's modification time remains unchanged until the application is restarted.

Steps to reproduce

  1. open an existing file
  2. edit it
  3. close
  4. see the error: file modification time does not change

https://github.com/gsantner/markor/assets/31406320/1ba0560b-759a-4b54-9948-420c21b23023

Information

Android version: 8 Device: pixel2 App Version: 2.11.1

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-
gsantner commented 6 months ago

@XYIheng Can you try a APK you can find on any of the development builds here https://github.com/gsantner/markor/actions? As the file metadata caching was reworked this should not be case in the master branch anymore.

XYIheng commented 6 months ago

@gsantner Hi, it still does not work for me. I try the apk here https://github.com/gsantner/markor/actions/runs/7493416005. The file's modification time remains unchanged until the application is restarted.

guanglinn commented 3 months ago

@gsantner We should call notifyItemChanged(position) or notifyDataSetChanged() after some files were modified.

gsantner commented 3 months ago

On pull down reload we also do that as far I know. But the info might be cached somewhere