Closed elyahw closed 7 months ago
Hi, @elyahw , this feature you expected has been implemented in PR #2211.
@guanglinn Thank you. It's very good. The one I had in mind is to be highlighted briefly then the highlighting would disappear. Unfortunately I have no experience in Android so I can't comment on the implementation.. Thanks!
Thanks for your suggestions, I made some improvements again.
Is this feature broken now? It does not seem to be working at all.. @guanglinn @gsantner
Hi, @elyahw , the feature I improved is here, but it was not merged. This feature has been modified by @harshad1 , it now cannot automatically highlight the file item when you click 'back' button.
@guanglinn / @harshad1 Humbly said: We rewrote that blinking many times now and it somewhat never worked THAT really well or was that good recognizable. Instead of reworking it for the Nth time, might be better to take a different approach. I.e. existing scroll + constant highlighting of that last item. So no animation/blinking/transparency.
Blinking is just one way to give the needed information. But just because we had it in the past, doesn't mean we can't replace it with something else, or need to keep beating it till it finally works good enough 😄
Thanks @guanglinn. I agree with @gsantner. Perhaps I said otherwise before, but "existing scroll + constant highlighting" is better. I recently saw it implemented in a File Explorer app called Mixplorer
, and it works very well (the highlight colour is very light).
Right now we blink when we
Blinking the file when one navigates back from the file should be doable.
Or we could use / simulate the android ripple effect if blinking is considered ugly
Unfortunatley neither works fine atm, either barely noticable or when coming back from editor not triggering at all
Perhaps another advantage of constant highlighting is that even you scroll through the notes, you can have a better sense of location (where you were). I would vote for this rather than blinking.
Windows File Explorer is well in the sense of location. It doesn't have complex animations.
Better sense of location involves highlighting the file/directory location and accurately restoring the scrolling position.
What I am getting is that consistent scroll positions as one navigates would be a good first step
@guanglinn @elyahw In #2307 I have added saving and remembering scroll positions. Please review and test.
⚠️ This issue respects the following points: ⚠️
Description
Information
Android version: 13 Device: Pixel 5a App Version: 2.11.1
Source
GitHub Releases
Format / File type
Not specific
Additional info / Log