View-Mode: Make search match scrolling instant instead of smooth scrolling to it - Githubissues

gsantner / markor

Text editor - Notes & ToDo (for Android) - Markdown, todo.txt, plaintext, math, ..

https://github.com/gsantner/markor/discussions/2269

Other

3.82k stars 365 forks source link

View-Mode: Make search match scrolling instant instead of smooth scrolling to it #2339

Open hiasenddup opened 4 months ago

hiasenddup commented 4 months ago

⚠️ This issue respects the following points: ⚠️

[X] This is a enhancement/feature request. Not a bug or question.
[X] #2353
[X] Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
[X] The wanted feature/enhancement is not present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor's settings are not touched. If your desired feature is present, you don't need to open this issue. The change will be part of the next Markor update.)

Description

Cancel the transition animation of search. There was no up and down transition animation when using search in Android 9 system, but in later Android systems, an additional transition animation appeared, which affects the search speed

All system animation times have been set to zero This runs on the Android 9

https://github.com/gsantner/markor/assets/105597818/c615379d-f1ef-4b6d-983d-e2fbed122c57

This runs on the Android 13

https://github.com/gsantner/markor/assets/105597818/80eb4fd8-2931-46df-8ac1-2615c1823cfb

Information

Android version: 13 Device: App Version: 2.12.2

Source

F-Droid

Format / File type

Not specific

Additional info / Log

gsantner commented 4 months ago

Can you add a short clipped video of what you mean? the search is a custom dialog and not any system aware search dialog. Not seems slow to me.

harshad1 commented 4 months ago

I don't think we have any dialogs which take > 250ms to appear.

hiasenddup commented 4 months ago

All system animation times have been set to zero This runs on the Android 9

https://github.com/gsantner/markor/assets/105597818/c615379d-f1ef-4b6d-983d-e2fbed122c57

This runs on the Android 13

https://github.com/gsantner/markor/assets/105597818/80eb4fd8-2931-46df-8ac1-2615c1823cfb

hiasenddup commented 4 months ago

@gsantner @harshad1

The operational video has been added. Thanks for your attention to this query.

Benko111 commented 4 months ago

If you could specify a precise timestamp it would make it easier to get what you mean. For my part, I'm currently not sure I understand the issue.

gsantner commented 3 months ago

OK so whats in question is that in view-mode, if it can be changed so the search not fluid scrolls to the match but instead immediate jumps to it.