gsantner / markor

Text editor - Notes & ToDo (for Android) - Markdown, todo.txt, plaintext, math, ..
https://github.com/gsantner/markor/discussions/2269
Other
3.85k stars 370 forks source link

v2.12.3: no more custom js in .md or csv files, just .txt or other misc text files #2365

Closed gesu92 closed 4 months ago

gesu92 commented 4 months ago

⚠️ This issue respects the following points: ⚠️

Description

Hello mister, I just update Markor today and noticed that the js custom script it's not execute in .md or .csv files like previus versions, just execute in .txt files u other random text files.

Steps to reproduce

  1. Load javascript in the settings
  2. Open .md or .csv file, nothing happend.
  3. Open other random text file, here is it the javascript.

Information

Android version: 14 Device: Moto X4 App Version: 2.12.3

Source

F-Droid

Format / File type

Not specific

Additional info / Log

No response

gsantner commented 4 months ago

This is about Inject-head settings options right?

gesu92 commented 4 months ago

Indeed, in the 2.13.3 there is no more javascript executed in .md and .csv files, I had to downgrade one version of the app meanwhile its solved

harshad1 commented 4 months ago

Could you give me an example with some instructions so I can test it?

gesu92 commented 4 months ago

Yeah, I mean, just use some javascript code that can be visually checked, like mmm document.getElementsByTagName("table").item(0).setAttribute("style","background-color: red;");

that should work in .csv and in a .md with a table

gesu92 commented 4 months ago

I have a bigger script that I ised with Markor. First I was thinking that some part are wrong, but casually open a .txt file and work, but in the custom files like .md and .csv does't

gsantner commented 4 months ago

Not sure about your problem, but your question seems to be rather about web development then Markor.

It works here at least:

screenrecord-2024-07-27_14.22.44.webm

gesu92 commented 4 months ago

It's not working mr.

https://github.com/user-attachments/assets/363a85c3-f4c4-41ef-9eb0-d307266f575e

gesu92 commented 4 months ago

The video show How the script works on random .txt files, but in .csv or .md it's not working, in the versión 2.12.3

In the 2.12.2 working fine, if you need I can do the same video but with the 2.12.2 version

harshad1 commented 4 months ago

I see this. Will investigate