gsantner / markor

Text editor - Notes & ToDo (for Android) - Markdown, todo.txt, plaintext, math, ..
https://github.com/gsantner/markor/discussions/2269
Other
3.85k stars 370 forks source link

v2.12.4 File browser: Opening files witout extensions opens the "Open with" dialog #2381

Open wshoy opened 3 months ago

wshoy commented 3 months ago

⚠️ This issue respects the following points: ⚠️

Description

Opening files without extensions shouldn't open the "Open with" dialog. It is the case, but you need to restart the app.

Steps to reproduce

  1. Create a file without extension
  2. Open the file - the "Open with" dialog opens (incorrect behavior)
  3. Close the app
  4. Open the app
  5. Open the file again - the "Open with" dialog doesn't open (correct behavior)

Information

Android version: 13 Device: App Version: 2.12.4

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-
gsantner commented 3 months ago

I would say it's correct to ask to select which app to open with. Just like most other file managers do it for extensionless or unknown mime typed files.

Mime Type is not always clear/extractable and without a hint by file extension it is not always clear whats in the box. Hence good to ask about opening in what app.

wshoy commented 3 months ago

Most files without extensions are text files. Markor is a text editor, so it's reasonable to treat the file as one.

jasonwryan commented 1 month ago

I ran into this, so I looked at the Settings. Under

Settings > General > Always open with this app

I read that:

Use 'None,.html,.css,.js' for example if you want to edit web files *and those without file extension.*

So I tried entering "None" and "none" but was still prompted after restarting the app.

I keep personal notes in plain text without a .txt extension and it would be great if this functionality works as documented.

Thanks!