Checkboxes in "Date and time" action button dialog not saved

wshoy commented 3 months ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug. Not a question or feature request.
[X] The topic is not already reported at Issues. (I've searched it).
[X] Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
[X] The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

"Get format instead date or time" and "Always use current date & time" checkbox values are not saved.

The latter checkbox always needs to be unchecked first to pick the date or time. This is not the implied behavior.

Steps to reproduce

Click on the "Date and time" button
Check/Uncheck either checkbox
Click "OK"
Click on the "Date and time" button again

Information

Android version: 13 Device: App Version: 2.12.5

Source

F-Droid

Format / File type

Not specific

Additional info / Log

gsantner commented 3 months ago

Let me ask other way round, why would you expect them to be saved?

Especially using something other then the current date is rather the rare case. Or inserting a date format you entered in the textbox.

wshoy commented 3 months ago

Indeed, saving the first one doesn't make much sense.
The word "always" in the second one implies, that it's saved.
The second checkbox looks like it doesn't do anything except reset to the current date. It could as well be something like a button (not sure). The "Pick Date/Time" buttons don't need to be disabled.

Regardless, I don't use it anymore from now on. I was using it for the due date in ToDo. Apparently there is already such thing which I've overlooked called the "Current date". 😅 Shouldn't it be called the "Due date"?

gsantner commented 3 months ago

Always diaables the date & time picker and makes the current time to be used. Well it's always checked. The usage has nothing todo with the checkbox checked state however.

harshad1 commented 3 months ago

IMO the fix is to remove 'Always'. Just

'Use current date/time'

gsantner / markor