gsantner / markor

Text editor - Notes & ToDo (for Android) - Markdown, todo.txt, plaintext, math, ..
https://github.com/gsantner/markor/discussions/2269
Other
3.85k stars 370 forks source link

Override .org file extension to use text mimetype (*/* unrecognized on older devices) #2455

Closed antler5 closed 1 month ago

antler5 commented 1 month ago

Prevents QuickNote.org from being filtered out of the QuickNote file-picking dialog.

gsantner commented 1 month ago

Thank you, but if we explicitly make some remapping here..better to somewhat the right type

text/org https://orgmode.org/worg/org-media-type.html

On my device at least, in current release, a orgmode file is already recognized as a text/plain, without this change.

antler5 commented 1 month ago

Ah, I haven't filled out the device information box that would have been in the template if i'd opened an issue -- i stopped getting android updates many years ago

It's up to you whether that's worth merging a fallback for, but ime there's (evidently) no way for a user who wants this to work around their android's poor mimetype api without forking to extend the list. with that in mind, i don't care what the mimetype is as long as it starts with text/ >u<

i think i'm against filtered file-pickers without user-facing toggles in general, but idk java so i stopped when i'd fixed my problem -- maybe another day if that'd be a preferred solution

Screenshot_20241021-171419_Markor.jpg

gsantner commented 1 month ago

Does it show up with text/org mime type now on your device, and it properly opens the files in editor on click?

Here it says text/plain and it works out of the box, but if we explicitly override..org is the better choice

antler5 commented 1 month ago

Does it show up with text/org mime type now on your device, and it properly opens the files in editor on click?

Yep, opens as-expected (in the correct mode) ~I do wonder what would happen if QuickNote was set to a .jenc file~

Screenshot_20241022-163717_Marder.jpg