search

gsantner / markor

Text editor - Notes & ToDo (for Android) - Markdown, todo.txt, plaintext, math, ..
https://github.com/gsantner/markor/discussions/2269
Other
3.85k stars 369 forks source link

Update links #2466

Closed leoheitmannruiz closed 1 week ago

leoheitmannruiz commented 3 weeks ago

The fdroid.app: thingies don't seem to render correctly https://f-droid.org/packages/net.gsantner.markor/

Also, it seems Markor is the only app in F-Droid that uses them:

$ grep "fdroid.app:" index-v2.json | wc -l
       1

Perhaps it makes sense to update the links here and deprecate the fdroid.app: thingies over at F-Droid. I'll ask them.

gsantner commented 3 weeks ago

Hello, Does the new link open thr entry in F-Droid app if you have it installed? Thats what that prefix is about

leoheitmannruiz commented 3 weeks ago

Oh, huh.

No. But currently they don't, either.

leoheitmannruiz commented 3 weeks ago

Internally, by F-Droid, the fdroid.app: links are converted to "normal" ones anyway: https://gitlab.com/fdroid/jekyll-fdroid/-/blob/f18e1ccf4119264f6ca045800fcaaecc14e6d71d/lib/fdroid/Package.rb#L170

gsantner commented 3 weeks ago

it would just be good to use links that lead to Markor entry inside app.

As far I see www.f-droid.org, but not without www is registered.

leoheitmannruiz commented 3 weeks ago

it would just be good to use links that lead to Markor entry inside app.

I don't know if it's possible. Does it work on your end? Regardless, I doubt it's going to be with fdroid.app: links.

As far I see www.f-droid.org, but not without www is registered.

Where do you see this?

gsantner commented 3 weeks ago

Screenshot-20241031-150524-Einstellungen.png

leoheitmannruiz commented 3 weeks ago

Oh sorry. I use F-Droid Basic and apparently it doesn't handle f-droid.org links, so I was little confused. But I installed the normal F-Droid client now and indeed it opens the links! So this PR should be good to go!

leoheitmannruiz commented 1 week ago

Nice! Anything I have to do here?