search

gsantner / markor

Text editor - Notes & ToDo (for Android) - Markdown, todo.txt, plaintext, math, ..
https://github.com/gsantner/markor/discussions/2269
Other
3.81k stars 366 forks source link

Allow to disable Chrome Custom Tabs, use other installed browser/app #686

Closed mat-ale closed 2 years ago

mat-ale commented 5 years ago

Description

Hi,

could you please add the possibility to choose whether opening URLs with "Chrome Custom Tabs" feature (currently as default) or with other system apps (by calling the system API to choose the application the user wants to use)?

Thanks

gsantner commented 5 years ago

Markor doesnt open URLs in webview. Only local files.

mat-ale commented 5 years ago

I have YouTube URLs e.g.

[YouTube url](https://youtube.com/watch?v=f4Mc-NYPHaQ)

and when I click on it the link opens in-app, without asking to use any other external app

gsantner commented 5 years ago

Ah, no thats not internal WebView. It's your browser, using a custom tab (https://developer.chrome.com/multidevice/android/customtabs).

You can move on from there to any other app using the menu

Screenshot_20190924-083103_Fennec_F-Droid

mat-ale commented 5 years ago

Ah ok, nice thanks

mat-ale commented 5 years ago

Hi,

would it be possible to add an option to avoid opening URLs in the custom tab and just call the system app selector API in order to directly use my favourite app to open links (e.g. for YouTube links I have the mobile app which I would like to use instead of first see the browser custom tab and then select the option to open with other apps)?

Thank you!

gsantner commented 5 years ago

@mat-ale please rename issue accordingly and update description. I know how to make this and it's very easy. But I know hacktoberfest is currently on and would like to leave this for the community, as a easy way to contribute to Markor.

mat-ale commented 5 years ago

@gsantner done! Thank you