search

gsantner / markor

Text editor - Notes & ToDo (for Android) - Markdown, todo.txt, plaintext, math, ..
https://github.com/gsantner/markor/discussions/2269
Other
3.51k stars 348 forks source link

Markor Project discussion, chat & questions #95

Open gsantner opened 6 years ago

gsantner commented 6 years ago

Do you have a question or a problem?

--> Check this: https://github.com/gsantner/markor/discussions/2269

To write comments a free GitHub account is required, the place where many Open Source software projects (like Markor) are developed.
Please don't send e-mails to developers, do ask & search here instead so everybody can benefit from your matter and it's answer/solution, as well other people might have a better answer.

Please subscribe/unsubscribe to this topic if you want to keep updated with whats going on in the project. It is kind of a "mailing list" for the project.

Notes:

uheinema commented 4 years ago

Long-press and info...feeling stupid. Not the best option, there is a lot of room after the date etc, and just the end of the path would suffice.

Thank you for your fast answer, really appreciated

rfn0 commented 4 years ago

Hi there, Could anyone help me figure out how to change the color of the 'underline' below the headings and the 'box' of the table of contents?

harshad1 commented 4 years ago

@rfn0 Do you mean in the 'view' mode for markdown?

rfn0 commented 4 years ago

@rfn0 Do you mean in the 'view' mode for markdown?

@harshad1 Yes. Sorry for being not clear

PrSunflower commented 3 years ago

Hello! First I would like to say thank you! I am using Markor as my daily note-taking app and together with Syncthing it has completely replaced OneNote, which I was using before. Thanks to all the developers who contributed to this magnificient app.

I have a question: long ago I had enabled an option when if you're in Edit Mode you could switch to View Mode by swiping the screen. I would like to disable that but I can't find it anywhere in the settings ...

Additionnal info

I want to disable it because I have markdown notes that have long pieces of code in them. In View Mode when I am scrolling to see hidden code at the right it switches to Edit Mode, which I don't want. And so I cannot read my code in View Mode because that option is activated.

rfn0 commented 3 years ago

@PrSunflower Options (3 dot) Settings View mode Swipe to change mode

PrSunflower commented 3 years ago

@rfn0 Thanks for replying.

I cannot see "Swipe to change mode" :/

Screenshot_20200821-100855

Build information

Package: net.gsantner.markor Version: v2.3.2 (116) Flavor: Default (release) Build date: 2020-07-29T08:02Z ISource: com.google.android.packageinstaller VCS Hash: 73c73f21ffecbdec2d35bae8e0472980572af8e5

rfn0 commented 3 years ago

@PrSunflower Did you enable experimental features? Options Settings General Experimental features

PrSunflower commented 3 years ago

Thank you very much for your help.

Experimental features were disabled in General and by reactivating them I got to see "Swipe to change mode".

Screenshot_20200821-103401

I must have enabled the experimental features a long time ago but I don't remember having disabled it.

Everything is working fine for me now, thanks a lot!

michaelcosj commented 3 years ago

Hey there, I can't seem to be able to create a new folder in app, I usually have to create the folder in a file manager and then access it from the app. I don't know if there's a button or option I can't find or if it isn't available on the app.

Also, I want to say that I really love markor, it's pretty much the best note taking app and mark down editor on android. I'm very grateful to everyone involved in this project, it has really helped me a lot.

gsantner commented 3 years ago

Press the bg red "plus button". In the dialog enter the name and press "FOLDER" on the bottom-left.

michaelcosj commented 3 years ago

Ohhh, ok, Thank you!!

damionx7 commented 3 years ago

I have applied this css to view mode but its not changing the heading color. How should I change the color of Headings in view mode ?

<style>
h1, h2, h3, h4, h5, h6 { color: orange !Important; 
font-variant: small-caps;
font-weight: 500; 
} 
</style>
ghost commented 3 years ago

is there any way to prevent text link to be linked and small when editing? really hard to see them

Screenshot_20200920-152606

harshad1 commented 3 years ago

@gsantner would you be interested in a pr to reduce the minimum action spacing? The minimum spacing is a little large on larger devices.

gsantner commented 3 years ago

@harshad1 For phones I want to keep it as is. For i.e. tablets or larger it's OK to me.
Relevant: appendTextActionsToBar(). There is some existing tablet check code in markor repository and for sure in memetastic (on my gh account).

BeayemX commented 3 years ago

What's your opinion on changing the icon for text files in the file browser? When skimming through directories I find it often hard to distinguish between files and folders at the first glance.

I think it would suffice if the text file would be displayed as an empty rectangle with some horizontal bars in it.

gsantner commented 3 years ago

Please share suggested folder+file icon comparision for new and old, in both dark and light. (side by side)

BeayemX commented 3 years ago

Can you point me to the directory where the current icons are stored so I can adapt them?

gsantner commented 3 years ago

res folder xml vectors.

i suggest todo just screenshot and edit in gimp/photoshop etc for the mockup.

however ahead: Markor uses the standard material design icons for File and folder. Unless its promising I dont see the need to make a change to something bareley anybody knows.

BeayemX commented 3 years ago

I imagened something like this light_double dark_double

BeayemX commented 3 years ago

@gsantner any update / feedback on this?

Also, another thing: The two dots on top of every folder to jump to the parent directory. Are these necessary? I always use the back key to jump to the parent directory. Or would it make sense to make an option to hide this entry?

harshad1 commented 3 years ago

@gsantner Would you be interested in accepting a PR to add a per-file wrapped / unwrapped setting? i.e. wrapped / unwrapped state will be settable in the file menu and will be remembered per file. I feel this can be very useful as some files are easier to manage when wrapped while others are easier to mange when not wrapped.

gsantner commented 3 years ago
harshad1 commented 3 years ago

Here is what I think this will look like:

image

The 'wrap words' option in the main settings will be the default option for new files. For each file, the above menu item will toggle the wrap state and this will be remembered per file. For example, I prefer if my quicknote and todo files are wrapped and that my projects.md file (which has several tables etc) remains unwrapped.

gsantner commented 3 years ago

thats what I mean with the second bullet

harshad1 commented 3 years ago

thats what I mean with the second bullet

Sorry, I'm not sure I fully understand.

To be clear, I am not proposing that we add a settings option to mark a specific path as wrapped or unwrapped. What I am proposing that In the editor menu there will be a toggle for wrap, and that the toggle state will be remembered per file path.

gsantner commented 3 years ago

Yes I know, and I say fine - but only when we do that for some other things too. Having only one per-file setting just is bad, and the first question is by user why setting X has no per-file or why setting Y has no per-global.

harshad1 commented 3 years ago

Ah got it! Thanks. What are the settings which we want per file?

Jaaaarne commented 3 years ago

Could anyone please recommend a file manager that will work with Markor? At the moment I can't seem to find any. Material Files from F-Droid doesn't work with it, and always using the built-in Markor file manager is painful, tbh. Thank you, and sorry for the trouble. :)

gsantner commented 3 years ago

For example

Schlichter Dateimanager (A simple file manager for browsing and editing files and directories.) - https://f-droid.org/packages/com.simplemobiletools.filemanager.pro

I myself though, since Markor file browser supports any file type via ("do you want to open with markor or external app") ...... very often use Markor itself as lightweight file manager. Of course not a recommendation for everybody, but thats just the filemanager I'm most familar with :D.

harshad1 commented 3 years ago

@gsantner I just realized that the indent size (tab width) option is experimental and defaults to 1. I guess I just set it a long time ago and forgot. I think we should default it to 4 and move it out of experimental.

The original markdown spec calls for 4 and commonmark requires 3 for single digit lists and 4 for double digit lists.

gsantner commented 3 years ago

Aa far I can say it is 1 because thats Android default, and non-default comes with noticeable performance penalty - which is the reason for default 1

harshad1 commented 3 years ago

comes with noticeable performance penalty

I believe larger indents do not cause a performance penalty any more. And the default of 1 is not correct for markdown.

gsantner commented 3 years ago

so is it about Tab Width (a tab character rendered as amount of X space characters)? Or something else? For the first, I have in mind it may slow done or make other issues on some devices, and thus was reverted to android default value.

https://github.com/gsantner/markor/commit/c86617255a46a4ceff7d420be65a3536c0a1da77

harshad1 commented 3 years ago

so is it about Tab Width

Ah. The fundamental issue is that we are using this setting for 2 different things.

  1. The numebr of spaces = one tab
  2. Number of spaces to indent / de-indent by

These are 2 different things and should have 2 different settings. Tab size should be hidden and have default = 1. I will make a PR to add a separate setting for indent size with default = 4 (per markdown)

gsantner commented 3 years ago

@harshad1 Ah.

My suggestion: Long press=last used indent button size. short press = popup with searchdialog with options 1/2/3/4 (similar to others). And no additional settings option

harshad1 commented 3 years ago

Hmmm. ok, yeah, thats pretty good.

gsantner commented 3 years ago

Hey everybody,

today Markor v2.5 update got released. Depending on F-Droid and Google Play's review / build period it may take some time to be available there. The apk is also available from GitHub.

Here is a insight of all the additions, fixes & changes:

Blog Post: Markor v2.5 - Zim Wiki - Search & Replace - Zettelkasten

grafik grafik grafik

---------------------------------- ping @harshad1 @pschwede @fredericjacob

jnstllng commented 3 years ago

Is there a limit of maximum lines or characters for syntax highlighting in markdown files? I realized that md files with more than 2000 lines do not have this anymore. Is this a wanted behaviour e.g. because of possible performance issues? Is it possible to change this limit value?

gsantner commented 3 years ago

@jnstllng The limit is by amount of characters, not lines. It is 100000 characters on todays devices (multicore, multiple GB ram) and 35000 on low end devices. It is a hard limit we found that works good for most cases.

jnstllng commented 3 years ago

The limit is by amount of characters, not lines. It is 100000 characters on todays devices (multicore, multiple GB ram) and 35000 on low end devices. It is a hard limit we found that works good for most cases.

Thanks for letting me know. I just checked my files and those which are not working with highlighting are having > 130.000 characters and are yearsly note files. It would be nice to change this to a values that can be set in the settings, maybe combined with a warning.

gsantner commented 3 years ago

Markor has very much configuration options, and I always ask if it makes sense to add option - does it REALLY help many people, while not bloating the app too much. I currently say no to adding it.

jnstllng commented 3 years ago

@gsantner Fine for me, not a big deal not to have highlighting for those big files. You are right, all the settings help to suit Markor to almost everybody's needs...

harshad1 commented 3 years ago

@gsantner @jnstllng Since we now have the ability to turn off / on highlighting on a per file basis, we can do something like the the following:

  1. Turn off highlighting when a file is > 100000 chars.
  2. If user manually turns on highlighting for a specific file, then remember this option for this file

We should not require any new settings for this and it will give users flexibility while being default-safe.

poisonborz commented 3 years ago

Hey, I have a question on the license: https://github.com/gsantner/markor/blob/master/LICENSE.txt Specifically:

Licensed under either of:

  • Apache 2.0 (see below)
  • Commercial (request via given contact details)

Apache 2.0 allows for commercial usage of the source. But here there is a separate "Commercial option"? What does "either of" mean? (if I understand right, and commercial usage isn't allowed, then the licence simply wouldn't be Apache 2.0 I guess?)

gsantner commented 3 years ago

@poisonborz This is mainly for the reason that I do/want to keep exchange code between my open source projects without license notice (aka "relicense"). There is for example a bigger amount of shared common utils I develop for all of my apps, and add new stuff over time. (like this one here https://github.com/gsantner/memetastic/commit/7c7a1a75db0749be64b24aae26580f2bdb3898c9 ). And all of my projects have different main licenses, i.e. GPLv3, Apache, MIT, ...

As sole author of most things anyway no problem, but still want to make sure with the "Commercial" part that I'm kept allowed to share the code between my projects, and I don't need to cross reference my projects i.e. dandelion <-> Markor <-> MemeTastic <-> OpenLauncher. I don't have the time to reinvent sharable code over and over, plus I can improve all of my projects when I improve at once. So theres the heading at these files which tells either Apache, or commercial/relicense allowed for me.

-> Keeps me allowance to share code without any license notice. Of course there are certain things in there repo from i.e. writley which are not covered, but anyway I don't need or want to exchange them as they are specific to markor & markdown editing :D.

And of course, the examples are public domain.

poisonborz commented 3 years ago

@gsantner So if I understand this preamble is because you use libraries that have various different licenses, and this is basically saying "my direct contribution on this project is Apache 2.0, and any other included libraries might have other licenses ('Commercial' or 'check them yourself')"?

gsantner commented 3 years ago

External libraries always hvae own licenses, don't matter.
But if you contribute to the code & files (i.e. with the apache2+commercial file header) that are up for sharing between my projects , then you give me the right to keep exchanging that portion of code/changes on that file.
This mainly there for the /opoc/ subfolder ("one piece of code" / "snippets") 😃

I could also make a real full library out of that, but till date I just copied & synced the java files between my project - that was the minimum effort so far.

I have developed and invested very much time in making utilities like tinting icons, like settings, like checking if launchers are enabled...and I just want to keep the right to do with that what I want.

As I'm anyway owner of the project AND 99.9% sole author of the files at /opoc/ anyway it shouldn't be needed, but still I wanted to have it there just in case.

poisonborz commented 3 years ago

I understand, just wanted to say that from a legal perspective this is not really required as far as I know - you can copy your own work freely between projects, regardless of licenses. When you copy a lib from your own MIT project to your own Apache project, it becomes relicensed automatically under the new one, as it was original work. Any piece of code not falling under a specific license is muddy water, especially if you mention "Commercial use".

But if you contribute to the code & files (i.e. with the apache2+commercial file header) that are up for sharing between my projects , then you give me the right to keep exchanging that portion of code/changes on that file.

I have developed and invested very much time in making utilities like tinting icons, like settings, like checking if launchers are enabled...and I just want to keep the right to do with that what I want.

But that's the problem, those files are not clearly marked. As they are not separate libraries with their own license, they could be anywhere.

I'm just writing this as I was thinking of forking Markor for a hobby project. It's a way harder decision to invest time in something that could have legal muddiness later on. By saying "some of my code might have commercial licence" could make people not want to touch this as you theoretically could lay claim to anything based on it.

I'm not a lawyer or a corporation (this isn't legal advice :v), just a developer working on side projects. What I would suggest:

Otherwise this is in legal grey area of open source, and this makes it rather hard to reuse/contribute to the project.