Be able to hide undesirable memes

[KeronCyst]

from the "Create" tab and move them to a "Hidden" tab.

[gsantner]

@KeronCyst I did not yet implement this (and yet unsure if really needed) but I released some new features today. Custom image templates in a special folder are now scanned too

[gsantner]

If you need more information ask. This issue is an idea, and about people to start contributing to the project. It has not much information because I pasted many ideas/issues and just let them out at the same time :). If you are interested in working on this, and have questions I can give you more details on this.

Register on https://hacktoberfest.digitalocean.com/, send a PR to fix this and get your t-shirt for free (4 accepted PRs to same or different GitHub repositories needed) :). You have to mention the issue number in the commit/PR (e.g. fix #20 / about #8) Find more hacktober issues from my projects: https://github.com/search?&q=label%3Ahacktoberfest+user%3Agsantner

[lex111]

@gsantner As I understand, you need to do something like Favs, just for undesirable memes?

[gsantner]

Quite the opposite of Favs, yeah. Can even use the same way of storing the list of "hidden"/ignored memes, should be not too hard

[lex111]

Yeah, i.e. next to the star icon, there will be another icon, when you click on that, this meme is saved in a new tab Hidden (or Ignored?), which is displayed in the navigation drawer, and then this meme will no longer be displayed in the tab Create, is that correct?

[gsantner]

a context menu instead would be very cool, which than lists hide and favourite, which may be extended later.

The favourite still can stay, or be replaced by three dots which in turn opens contextmenu too.

there is already a kinda useless longclick Listener on item root, which is a point to start opening the contextmenu.

[gsantner]

Are you workinh on this @lex111 ?

[lex111]

@gsantner unfortunately no.

[aumarbello]

Is anyone working on this?

[gsantner]

No, but #70 may have some conflicting changes, so maybe wait a day for it to be merged

[aumarbello]

But i can start working on it?

[gsantner]

if you want, but note that you will have to deal with merge conflicts then. as said the other PR should be ready tomorrow

[aumarbello]

Okay will wait for the PR

[aumarbello]

Green light?

[gsantner]

@a-u-bello yes, I didn't merge the PR, so: Popup menu needs to be added first (working on grid and row layout) and in there the option to add/remove something to the hidden list

[aumarbello]

There's already a long click to show title, should i replace the long click with a pop up menu with items for the title and hiding a meme?

On Wednesday, October 18, 2017, Gregor Santner notifications@github.com wrote:

@a-u-bello yes, I didn't merge the PR, so: Popup menu needs to be added first (working on grid and row layout) and in there the option to add something to the hidden list

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.< https://ci4.googleusercontent.com/proxy/V_M0SG8pU4cZ-67pKrKApiyFFQiVATPmxruoZ-6WQzdg1Bh5cwt1N9-Cc21Y5fp9L5xhkjHrh2zLMgM-5qNv4frtf2e1UFSakQSlDmkWdePdOcrWPk8yx1SWdCb-MZQEn-m6FNomWIfnBJIdwbAlgutRT_Jr6g=s0-d-e1-ft#https://github.com/notifications/beacon/AbPFPfCuavcXjwG2Z7Lwwn2VUFLLu6Loks5stlMugaJpZM4NoyLx.gif>

[gsantner]

exactly.replace longlick. maybe add favourite as option too there

Am 19. Oktober 2017 10:38:44 MESZ schrieb Ahmed Umar notifications@github.com:

There's already a long click to show title, should i replace the long click with a pop up menu with items for the title and hiding a meme?

On Wednesday, October 18, 2017, Gregor Santner notifications@github.com wrote:

@a-u-bello yes, I didn't merge the PR, so: Popup menu needs to be added first (working on grid and row layout) and in there the option to add something to the hidden list

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.< https://ci4.googleusercontent.com/proxy/V_M0SG8pU4cZ-67pKrKApiyFFQiVATPmxruoZ-6WQzdg1Bh5cwt1N9-Cc21Y5fp9L5xhkjHrh2zLMgM-5qNv4frtf2e1UFSakQSlDmkWdePdOcrWPk8yx1SWdCb-MZQEn-m6FNomWIfnBJIdwbAlgutRT_Jr6g=s0-d-e1-ft#https://github.com/notifications/beacon/AbPFPfCuavcXjwG2Z7Lwwn2VUFLLu6Loks5stlMugaJpZM4NoyLx.gif>

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/gsantner/memetastic/issues/14#issuecomment-337839419

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

[aumarbello]

Okay, would implement it like that

[aumarbello]

Observed a bug with the viewpager, when you are in the first tab human in create, clicking create again in the nav bar will move to the next tab, check to confirm.

[gsantner]

you can fix any bug you find

[aumarbello]

Okay, will do