search

gsantner / memetastic

Meme Creator for Android - Simple & Ad-Free
https://github.com/gsantner/memetastic#readme
GNU General Public License v3.0
310 stars 122 forks source link

Feature Request: Custom text position #205

Open vtkhatri opened 4 years ago

vtkhatri commented 4 years ago

General information

Feature request

Description

Allow user to choose the position of text on image if they want to.

magnus-ISU commented 2 years ago

I feel like this is one of the most important things in a meme creator. I'll take a look at it later, but also want to add that the app is not very useful without this so I'm disappointed it isn't already implemented.

fridewald commented 2 years ago

So if I see this correctly there is only one Textview in the MemeCreateActivity which is fixed at the top. So if we want to get custom text position, we maybe need 2 Textviews that can be dragged and scaled, this would mean to rewrite a lot of the logic right now.

It might also be possible to make it with the current setup, but I'm not sure how one would then decide which text should be used. One could add some buttons to choose which text should be edited, and then only this text will get dragged around. In the case of dragging this would mean another click and you might press the wrong button.

So I think the proper way is to have multiple textviews in the end.

gsantner commented 2 years ago

Wrong, you have to differentiate between drawn overlay and the input.

For text input there is only one textield field, which is used for any input to any overlay field.

Currently there are two such drawn overlay fields, top & bottom.