search

gsarig / ootb-openstreetmap

A map block for WordPress' Gutenberg Editor which uses OpenStreetMap and Leaflet.js. It needs no API keys and works out of the box. Benefiting from Gutenberg’s potential, the plugin tries a different take on how to add your locations on the map and rethinks a few things, UX-wise. Install it from https://wordpress.org/plugins/ootb-openstreetmap/
29 stars 2 forks source link

Front end click on locator not working on Safari #1

Closed robertpassaro closed 1 year ago

robertpassaro commented 3 years ago

Excellent plugin!! I love this! I am finding one weird issue when I happened to be in Safari -- if you place a pin on the map, and click on it on the front end the pop-up does not appear. It seems to be working fine on Firefox and Chrome. Can you reproduce this?

gsarig commented 3 years ago

Hi Robert, thanks for your comment and sorry for the delayed response.

I don't have an actual map to properly try it, but I am testing it on an emulator, using lambdatest.com. I can confirm that the popup doesn't open when clicked. It does open if I click and hold for a while (1-2 seconds) and then release it. This seems to be a leaflet issue, as I notice the same behavior on their official example: https://leafletjs.com/

0dysseo commented 1 year ago

Hello Giorgios, greetings from France. Any update about this issue? I've installed your plug-in and actually one of my customers is experiencing the same problem. Pls let me know. Thanks in advance

gsarig commented 1 year ago

Hi @0dysseo This seems to be a Leaflet bug which, based on my tests, seems to have been resolved in the newer versions. I'm working on a big refactoring of the plugin, which will update Leaflet as well, and it should fix the issue. If you are interested in more details, you can check it out.

As I am working on it on my free time (usually the weekends), I expect to have it fully tested and released (hopefully) by the end of the month.

Unfortunately, Leaflet 4* had been a big upgrade, and parts of the plugin's functionality had to be rewritten to support it, that's why it took me so long.

In the meantime, if you want something faster, I've prepared a zip for you, and you can use the attached version of the plugin:

ootb-openstreetmap.zip

Just upload the plugin from the WordPress dashboard, and when prompted, allow it to override the existing one. Of course, I would suggest to test if first on a staging environment, as I have only tested it on very specific conditions (WordPpress 6.1, and PHP 7.4 and 8.0).

If you decide to test it, please let me know for any issues or bugs. On my tests it worked fine, but as I said, I only used a very specific environment so far.

0dysseo commented 1 year ago

Hello Giorgos.Thank you so much for your quick reply and the new plug-in version.I'll go to test it in the website preview release and I'll keep you posted.Best,MarcoMARCO BENAagence de communication____457 Avenue de VessyBâtiment A01210 Ornex+33 (0)7 61 57 80 90https://marcobena.euOn Sun, Nov 13, 2022 at 11:58pm, Giorgos Sarigiannidis @.> wrote:Hi @0dysseo This seems to be a Leaflet bug which, based on my tests, seems to have been resolved in the newer versions. I'm working on a big refactoring of the plugin, which will update Leaflet as well, and it should fix the issue. If you are interested in more details, you can check it out.As I am working on it on my free time (usually the weekends), I expect to have it fully tested and released (hopefully) by the end of the month.Unfortunately, Leaflet 4 had been a big upgrade, and parts of the plugin's functionality had to be rewritten to support it, that's why it took me so long.In the meantime, if you want something faster, I've prepared a zip for you, and you can use the attached version of the plugin:ootb-openstreetmap.zipJust upload the plugin from the WordPress dashboard, and when prompted, allow it to override the existing one. Of course, I would suggest to test if first on a staging environment, as I have only tested it on very specific conditions (WordPpress 6.1, and PHP 7.4 and 8.0).If you decide to test it, please let me know for any issues or bugs. On my tests it worked fine, but as I said, I only used a very specific environment so far.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: **@.>[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/gsarig/ootb-openstreetmap/issues/1#issuecomment-1312844543", "url": "https://github.com/gsarig/ootb-openstreetmap/issues/1#issuecomment-1312844543", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

gsarig commented 1 year ago

This should be fixed on v. 2.0.0