search

gsasansol / GirlScript-Asansol

Github repository for the official website of GirlScript Foundation's Asansol Chapter using Vanilla JS
https://girlscript-asansol.netlify.app
MIT License
53 stars 72 forks source link

revamped "past events" section #215

Closed KeneePatel closed 1 year ago

KeneePatel commented 1 year ago

Related Issue

Proposed Changes

Checklist

Screenshots

Before Before the changes

After After the changes

netlify[bot] commented 1 year ago

Deploy Preview for girlscript-asansol ready!

Name Link
Latest commit bb3e7f7b6dc1643cf111a44ffea86f69507d368e
Latest deploy log https://app.netlify.com/sites/girlscript-asansol/deploys/6350058f110d540008dfd7ad
Deploy Preview https://deploy-preview-215--girlscript-asansol.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

KeneePatel commented 1 year ago

forgot to mention the issue associated with this. #158 , So tagging the issue here.

Debdeep1 commented 1 year ago

forgot to mention the issue associated with this. #158 , So tagging the issue here.

The site isnt responsive for mobile view...please have a look at that...

regdocs commented 1 year ago

@KeneePatel Looks great but I think the desktop cards aren't hidden in mobile view. Can you check? Could you also add some padding to the mobile view cards?

Optional: The location of the slider arrows in mobile view seems unstable. We'll have another issue for this one if you like.

KeneePatel commented 1 year ago

Can you give me some direction on how would I be able to make the cards hidden in mobile view? Like in the site as of now, when we change to mobile view, It pretty much hides the text and shows one image per view. Am I supposed to do the same and if yes, can you give some specific references on where to look.

soumali28 commented 1 year ago

@KeneePatel just add a class name desktop-events in your main div (starting of the past events) it will work.

KeneePatel commented 1 year ago

Ayy thanks for the direction @soumali28. I did as you said and have requested a re-review.