Closed shahifaqeer closed 10 years ago
I'm going to wait on merging till all the framing work is done. (All the TODOs are done)
Please let me know if this is blocking anyone, I'll merge it off then. (Once the code is revised, ofc)
@shahifaqeer, any updates on the TODOs?
@shahifaqeer, Is this done?
Done. Ready for merge. Tested Assemble and Disassemble - they work perfectly.
Can you please rebase this on my current master? Thanks!
and the unit tests?
@ben-jones Yo can we haz code review?
@ben-jones can you please review this?