Adding setup.py - Githubissues

gsbDBI / ds-wgan

Design of Simulations using WGAN

MIT License

48 stars 16 forks source link

Closed halflearned closed 4 years ago

halflearned commented 5 years ago

This is necessary if we want call the wgan module from outside this repo's folder.

With this in place, a new user can type:

git clone https://github.com/gsbDBI/ds-wgan
cd ds-wgan
python setup.py develop

Notes:

I marked the development status as "alpha"
References to LICENCE are commented out, since this repo does not have a LICENSE yet.
Dependency requirements are now within the setup.py. (Btw, tqdm is listed, but it doesn't really seem to be used anywhere)

evanmunro commented 4 years ago

Tested and looks good, just figuring out the license and then can merge.

Once we have merged (FYI @Jonas-Metzger) I will make the corresponding changes to the Colab tutorial to use setup.py instead of requirements.txt.

halflearned commented 4 years ago

We can merge this first and add the license in a second PR that also uncomments the relevant lines.

Also,

pip install -r requirements.txt

should still work, so you could leave the code as is as well.

evanmunro commented 4 years ago

Can you double check the requirements.txt? The changes summary shows it being removed

halflearned commented 4 years ago

It's not removed, and it's not blank. It has a period in it. See e.g. top answer here.