search

gsbDBI / torch-choice

Choice modeling with PyTorch: logit model and nested logit model
MIT License
39 stars 8 forks source link

Undeclared dependencies #27

Closed grantmcdermott closed 1 year ago

grantmcdermott commented 1 year ago

Hey, thanks for this new package. Looks cool!

I hit an early snag trying to load the library after pip install; I don't think you've declared any of the dependencies. See the Requires field below.

$ pip3 show torch_choice                                                    ─╯
WARNING: Skipping /usr/local/lib/python3.11/site-packages/six-1.16.0-py3.11.egg-info due to invalid metadata entry 'name'
Name: torch-choice
Version: 1.0.2
Summary: A Pytorch Backend Library for Choice Modelling
Home-page:
Author: Tianyu Du
Author-email: tianyudu@stanford.edu
License: MIT
Location: /usr/local/lib/python3.11/site-packages
Requires:
Required-by:

This is easy enough to resolve manually using your requirements.txt file on the repo but it's not something you'd want every user to be doing.

TianyuDu commented 1 year ago

Hi Grant, thank you so much for the suggestion! We have updated the setup.py file accordingly to include this information. Now we have

Name: torch-choice
Version: 1.0.2
Summary: A Pytorch Backend Library for Choice Modelling
Home-page: https://gsbdbi.github.io/torch-choice/
Author: Tianyu Du, Ayush Kanodia, and Susan Athey
Author-email: tianyudu@stanford.edu
License: MIT
Location: /Users/tianyudu/miniforge3/envs/dev/lib/python3.9/site-packages/torch_choice-1.0.2-py3.9.egg
Requires: numpy, pandas, pytorch-lightning, scikit-learn, tabulate, termcolor, torch
Required-by:

The change will be reflected in v 1.0.3. Thank you!