Closed GoogleCodeExporter closed 9 years ago
Oh, the spelling also has to be changed in example/main.go.
Original comment by mi...@classroomsystems.com
on 2 Oct 2013 at 9:13
You should have told me long time ago :-). I don't want to break other people's
code. Here are couple of ways to fix it:
1) do nothing;
2) rename IsAnIinteractiveSession function to IsAnInteractiveSession;
3) add new IsAnInteractiveSession function that just calls
IsAnIinteractiveSession under covers.
Which one you prefer? Why? Did I miss any other alternatives?
Thank you.
Alex
Original comment by alex.bra...@gmail.com
on 3 Oct 2013 at 7:35
I hate leaving the misspelling alone simply because it's so easy to miss
visually. It took me a minute to figure out why my code didn't compile using
the correctly-spelled name. I favor option 3 (support both spellings), probably
with a note in godoc saying that the misspelled version is just for API
compatibility. Maybe the misspelled name could be removed if and when there's a
Go 2.
Original comment by mi...@classroomsystems.com
on 3 Oct 2013 at 5:37
Please, review https://codereview.appspot.com/14198044/. Thank you.
Alex
Original comment by alex.bra...@gmail.com
on 3 Oct 2013 at 11:50
This issue was closed by revision 0dd894180583.
Original comment by alex.bra...@gmail.com
on 4 Oct 2013 at 2:05
Original issue reported on code.google.com by
mi...@classroomsystems.com
on 2 Oct 2013 at 9:03