gschizas / fallenswordhelper

MIT License
1 stars 10 forks source link

Quick Links should not "push" everything down one line #342

Closed gschizas closed 9 years ago

gschizas commented 9 years ago

Original issue 343 created by gschizas on 2009-02-06T05:39:07.000Z:

What steps will reproduce the problem? (One defect per issue, please)

  1. Not sure if it is my DSL speed or because of the server lag, but:
  2. Almost any FS page, let say world page, when you move around
  3. The map appears first, with the monsters, everything ...
  4. Then the whole map get pushed down one line because of the Quick Links appearance. Since I focus on the map when lvling, it is kind of annoying!

What is the expected output? What do you see instead? may be move the quick link to the side (left/right), out of the player's focus, then the "push down" effect will not be noticeable.

gschizas commented 9 years ago

Comment #1 originally posted by gschizas on 2009-02-06T15:42:45.000Z:

I think it should be on the left under the log out button.

gschizas commented 9 years ago

Comment #2 originally posted by gschizas on 2009-02-07T01:36:49.000Z:

If possible, I think it should be a preference. I like it exactly where it is.

gschizas commented 9 years ago

Comment #3 originally posted by gschizas on 2009-02-07T02:45:32.000Z:

I am not a big fan of the push down either ... the big question is where to put it.

gschizas commented 9 years ago

Comment #4 originally posted by gschizas on 2009-02-27T11:16:19.000Z:

<empty>

gschizas commented 9 years ago

Comment #5 originally posted by gschizas on 2009-12-20T05:53:39.000Z:

The push down thing could be an after-effect of where the code to insert quick links is. Further down in the FSH code, there will be a delay before the links are drawn... if you catch my drift.

gschizas commented 9 years ago

Comment #6 originally posted by gschizas on 2009-12-20T05:58:01.000Z:

The push down thing could be an after-effect of where the code to insert quick links is. Further down in the FSH code, there will be a delay before the links are drawn... if you catch my drift.

But - as other issues have shown, quick links can screw things up if they are above other events. (issue 351)

gschizas commented 9 years ago

Comment #7 originally posted by gschizas on 2010-10-19T14:33:02.000Z:

i vote this to be fixed to .. or it would be better if there's an ajaxified show/hide button that is off to the side, but in a location where the load of that link wouldn't cause a shift. some of the links i have there are for MP, and auction house. great in the middle of a hunt, but too much to enable / disable hunt mode and wait for a reload. if something like this is possible, it would be great to disconnect quicklinks from hunting mode.

gschizas commented 9 years ago

Comment #8 originally posted by gschizas on 2012-01-11T13:04:08.000Z:

closing old / outdated issues