Support json-type (:hash-table object)

[riktam]

Allow json-type of (:hash-table object)

[kilianmh]

For a project of mine, I developed a bit more advanced solution where you can specify the hash-table key-type as well: (:hash-table key-type value-type). E.g. (:hash-table :string :number), or (:hash-table :any object)

This is my version:

(defmethod to-lisp-value ((value hash-table) (json-type cons))
  (destructuring-bind (type key-type value-type)
      json-type
    (ecase type
      (:hash-table
       (let ((hash-table
               (make-hash-table :size (hash-table-size value)
                                :test (case key-type
                                        ((:string :any)
                                         (function equal))
                                        (otherwise
                                         (function eql))))))
         (maphash #'(lambda (key value)
                      (setf (gethash (to-lisp-value key
                                                    key-type)
                                     hash-table)
                            (to-lisp-value value
                                           value-type)))
                  value)
         hash-table)))))

[riktam]

Are you sure that the "spec" allows for keys other than strings? I'm ok with with either implementation. My case only had string keys.

[kilianmh]

Actually you're right: keys in JSON Objects can only be strings. So your version is superior.

[gschjetne]

This looks good to me, but would you consider adding a unit test?

[riktam]

Added decoding, tests and updated the documentation.

[kilianmh]

You should probably squash the changes into one commit and rebase on master.

[riktam]

Done