search

gschramm / parallelproj

code for parallel TOF and NONTOF projections
MIT License
30 stars 9 forks source link

Typo in include #16

Closed KrisThielemans closed 2 years ago

KrisThielemans commented 2 years ago

https://github.com/gschramm/parallelproj/blob/master/c/include/parallelproj_c.h#L284 Has a ; at the end. Should be a comma?

gschramm commented 2 years ago

Thanks for spotting this typo Kris. It is fixed in version 1.0.1 https://github.com/gschramm/parallelproj/releases/tag/v1.0.1 https://github.com/gschramm/parallelproj/compare/v1.0.0...v1.0.1

On top of that, the cuda device kernels have been moved to a separate file such that they can be directly used by cupy (to run complete recons directly on the GPU without host-GPU transfers). Build process and API have not been changed.