Support (fieldless) enums in `Config::Input`

gschup / ggrs

GGRS is a reimagination of GGPO, enabling P2P rollback networking in Rust. Rollback to the future!

Other

507 stars 25 forks source link

Closed Vrixyz closed 1 year ago

Vrixyz commented 1 year ago

Improves #40.

in bytemuck, Pod trait was split in multiple traits in release 1.9.0 https://github.com/Lokathor/bytemuck/blob/main/changelog.md#190
NoPadding renamed into NoUninit: https://github.com/Lokathor/bytemuck/pull/94
There is no benchmarks, I think the impact should be very minimal, but I figured I would bring it up.

gschup commented 1 year ago

I like this. @Vrixyz what do you think: Is there anything else you want to add/change before we merge this?

Vrixyz commented 1 year ago

I'd like to make tests code quality better, I duplicated a lot of code and there may even be dead code.

A first step could be to:

merge this once a minimal cleanup is done
make a follow up issue to make more agressive improvements to the tests (generic tests over "CheckedBitPattern" ?)
make an independent followup issue to attempt support for enums with fields.

Vrixyz commented 1 year ago

I like this. @Vrixyz what do you think: Is there anything else you want to add/change before we merge this?

I'm done with this Pull Request, I'll address feedbacks only now :)