search

gschup / ggrs

GGRS is a reimagination of GGPO, enabling P2P rollback networking in Rust. Rollback to the future!
Other
507 stars 25 forks source link

Multiple Local Players not allowed, but should be already supported #54

Closed gschup closed 1 year ago

gschup commented 1 year ago

Describe the bug Looking at the SessionBuilder, I just realized that we do not allow multiple local players. I am however quite sure I implemented this functionality ages ago. The endpoints are set up to handle more than one player per endpoint, which requires more than one local player one at least one of the clients.

Expected behavior Adding more than one local player should be allowed. In the best case, this check can just be removed.

What to do Write a test case for this and maybe even extend the example. See if this actually works.

gschup commented 1 year ago

Turns out, the check is completely non-functional and cannot be reached.