search

gschup / ggrs

GGRS is a reimagination of GGPO, enabling P2P rollback networking in Rust. Rollback to the future!
Other
507 stars 25 forks source link

fix: Fix result error type for bitfield-rle update to 0.2.1 #73

Closed MaxCWhitehead closed 5 months ago

MaxCWhitehead commented 5 months ago

bitfield-rle just published version 0.2.1 which removes dependency on failure crate, which was failing advisories for being unmaintained.

GGRS uses bitfield-rle 0.2 (fix version not restricted), when crates depending on ggrs update bitfield-rle in lock file, there is a related compiler error due to bitfield-rle error type changing.

This should fix those issues and allow dependent crates on ggrs to upgrade bitfield-rle successfully.

MaxCWhitehead commented 5 months ago

It may make sense to pin the fix version of bitfield-rle (to 0.2.1 for example), because it is not 1.0, updates such as 0.2 -> 0.2.1 may contain breaking changes such as this one when abiding by semantic versioning.

MaxCWhitehead commented 5 months ago

Updated to pin version of bitfield-rle to prevent future upgrade failures such as: https://github.com/gschup/ggrs/issues/72

gschup commented 5 months ago

Thanks for tracking this down!