gsdriver / ssml-check-core

Core SDK for ssml-check
MIT License
13 stars 10 forks source link

media begin/end attributes don't handle syncbase values #2

Closed gsdriver closed 5 years ago

gsdriver commented 5 years ago

Describe the bug The begin and end attributes for Google's media tag don't recognize syncbase values

To Reproduce

<speak>
<media xml:id="words" begin="crowd.end-1.0s">
  <speak><emphasis level="strong">Great catch by Amendola! I can't believe he got both feet in bounds!</emphasis></speak>
</media>
</speak>

returns an error that crowd.end-1.0s is invalid

Expected behavior This is valid SSML on Google

Environment (please complete the following information):

gsdriver commented 5 years ago

Fixed in 0.1.3; updated the matching to include syncbase values