search

gsemet / kube-airflow

Helm chart to run production Airflow/Celery on Kubernetes
20 stars 8 forks source link

Contribute to kubernetes/charts #15

Closed gsemet closed 6 years ago

gsemet commented 6 years ago

When this chart is mature enough, let's contribute to incubator section of kubernetes/charts

rolanddb commented 6 years ago

@gsemet I see that you have a fork of kubernetes/charts from which you've created a PR.

How do you migrate files from this repo (kube-airflow) to the charts repo? Just copy them over?

Our team also has a fork of kubernetes/charts. I have to add kube-airflow there as well. So it seems to me, that we are doing things twice.

Maybe it is time, to move all the development work on this chart into the big charts repo? I think it can accelerate the final development.

gsemet commented 6 years ago

Yes that's planned. But I still receive interesting contributions here, so I do the copy manually from time to time. It's time consuming and inefficient, indeed.

I still have some reviews on the airflow charts to fix before it be officially merged. So, I see two solutions:

I think I'll go the the first option so I do not have manual operations anymore. Thanks for your remark, I think I'll do what you recommend

rolanddb commented 6 years ago

First option sounds good to me. I have copied my fork into https://github.com/Eneco/charts/tree/feature/airflow and will continue developing there.

gsemet commented 6 years ago

done on https://github.com/gsemet/charts/tree/airflow/incubator/airflow

gsemet commented 6 years ago

@rolanddb can you rebase on https://github.com/gsemet/charts/tree/airflow/incubator/airflow I have updated a lot of code but I do not have the possibility to test for a few days. Can you look at it?

rolanddb commented 6 years ago

I made some changes, but the upgrade of api versions means that this charts does not run on our cluster anymore (1.8.8). I'll continue on monday.