search

gsethi / addama

Automatically exported from code.google.com/p/addama
Apache License 2.0
1 stars 0 forks source link

Please review search unit tests #18

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Please review the search unit tests.  Specifically take a look at the TODOs in
the file and let me know whether modifying search to support those cases is an 
okay extension or will break the semantics you are going for with your search 
strategy.

------------------------------------------------------------------------
r265 | nicole.deflaux@sagebase.org | 2010-10-29 11:09:45 -0700 (Fri, 29 Oct 
2010) | 11 lines

Here is the fix to JcrSearchController to enable search over non-text fields.

new review:
owner: hrovira.isb
cc: aeakin@systemsbiology.org, mike.kellen@sagebionetworks.com
summary: Please review search fixs
labels: ReadyForReview
branch: /branches/deflaux/playground
Please review the search fix.  Specifically let me know whether modifying 
search to support exact matching against non-text fields will break the 
semantics you are going for with your search strategy.  If so I can revert this 
change and add an new search REST api to support this use case.

------------------------------------------------------------------------
r293 | nicole.deflaux@sagebase.org | 2010-11-04 16:39:26 -0700 (Thu, 04 Nov 
2010) | 13 lines

Extended JCR search controller to filter results to be those recently modified 
and to also paginate the results returned.  The API is working toward that of 
http://code.google.com/apis/gdata/docs/2.0/reference.html#Queries using the RFC 
3339 timestamp format. For example: 2005-08-09T10:57:00-08:00.

The use case I'm working toward is to retrieve a feed of recently 
created/modified nodes relevant to a particular project.  I am envisioning that 
all those nodes are tagged for that particular project and the search query is 
for that tag value filted by the updated-min date.

new review:
owner: hrovira.isb
cc: aeakin@systemsbiology.org, mike.kellen@sagebionetworks.com
summary: Please review new search filterss
labels: ReadyForReview
branch: /branches/deflaux/playground
Please review the new search filters.  This particular code change should not 
modify any current behavior, only extend the current behavior.

------------------------------------------------------------------------
r294 | nicole.deflaux@sagebase.org | 2010-11-04 22:04:57 -0700 (Thu, 04 Nov 
2010) | 3 lines

Added a comment about the efficiency of a recently added loop

------------------------------------------------------------------------

Original issue reported on code.google.com by nicole.d...@gtempaccount.com on 10 Nov 2010 at 12:45

GoogleCodeExporter commented 8 years ago 
Per a conversation with Hector, closing this CR request.  This code was merged 
to trunk via revision 303.

Original comment by nicole.d...@gtempaccount.com on 22 Nov 2010 at 10:54