gsiametis / dreampy_dns

Python script for updating Dreamhost's DNS custom records.
MIT License
23 stars 13 forks source link

Minor fixes necessary to get this to run with current Dreamhost. #4

Closed sutula closed 4 years ago

sutula commented 4 years ago

In my prior pull request, I responded incorrectly on a number of points. I don't seem to have any way to contact the author except through a pull request, so that is what is being done.

First, the changes in this pull request are necessary for the code to run under current Dreamhost. I suspect that they changed the format of some of their REST API responses since the code was first written.

Second, I am using Python 3, not 2. The changes I made should work for Python 3. (At least they do on my system.) In fact, the code you wrote does check for version 3 and fails early if that is unsatisfied. Are my changes the best/right way to make the change? I'm a total Python novice, so feel free to correct.

Last, if you have no desire to maintain this, just let me know and I'll update the README and maintain my fork as the public master version. (I'm still using it.) If you want to take this option, I'd want to ensure you receive credit for the authorship. That's already in the LICENSE file, but I'd be adding it to the README as well. If you want mention of your full name, I'd be happy to include it.