gsimon2 / dramatic-rolls

Foundry Vtt module
GNU General Public License v3.0
7 stars 4 forks source link

[BUG] cant add new files #9

Closed PalaNolho closed 3 years ago

PalaNolho commented 3 years ago

Hi,

I'm not able to add new sounds to the critical and fumble settings. when I click on the "add..." option it opens my system instead of the foundry file system.

This makes it impossible for me to add new sounds (Note: I'm using could hosting)

gsimon2 commented 3 years ago

Hi @PalaNolho, sorry you are experiencing issues.

Could you provided a few screen shots and more information? Like what are you using for cloud hosting? I will be able to figure out the issue better if I can reproduce your setup. Thanks.

PalaNolho commented 3 years ago

Hope this will help https://www.screencast.com/t/gXj9q5CtfcI

gsimon2 commented 3 years ago

Awesome video! The issue is making sense to me. I have not messed with cloud hosting Foundry yet so was unfamiliar with the workflow. I will work on cutting a fix for this as I get some free time and will keep you updated.

gsimon2 commented 3 years ago

@PalaNolho Hey had sometime to poke around at it and I think utilizing the FoundryVtt FilePicker should solve the issue for you. Please update to version 1.3.0 and let me know if this resolves the issue for you.

PalaNolho commented 3 years ago

@gsimon2 FYI, I see that there is a new 1.3.0 version and I see that the foundry page is also updated with it. But when I check for updates on the mobile, it's not picking up the new version.

Not sure if it's normal or not, but wanted to lt you know

PalaNolho commented 3 years ago

ok... now it's not working... now it doesn't play any sound at all when a crit or fumble is rolled. Not even the confettis trigger

already disabled modules to see who could be messing up but still nothing. I don't see any error in the console

gsimon2 commented 3 years ago

What version of Foundry are you using?

PalaNolho commented 3 years ago

0.7.9 There is not yet any stable release for 0.8.x

PalaNolho commented 3 years ago

0.7.9

There is not yet any stable release for 0.8.0

On Mon, 3 May 2021 at 12:19, Glen Simon @.***> wrote:

What version of Foundry are you using?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gsimon2/dramatic-rolls/issues/9#issuecomment-831196029, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABN3IOXKS5K3ZWTONTHI4G3TL2BDBANCNFSM43RL3STA .

gsimon2 commented 3 years ago

This one is sending me for a loop. I have uninstalled the modules from my machine and did a clean re-install and they are working fine. Tested them across multiple existing worlds of different systems as well as new worlds. I am unable to reproduce your issue. I will continue exploring, but it may take me a bit to find a solution.

If you need a quicker fix, I would be willing to hop onto the Foundry Discord server and chat. We may be able to figure it out if we sit down and walk through the steps together, but scheduling my be tricky.

PalaNolho commented 3 years ago

I went to tet again and on a new world, I was able to play the sounds.... (even the ones I selected from my filesystem)

I went back to my original world and tried again, (disabled EVERYTHING except the confetties and the dramatic module) and still no sounds on 1 or 20.

I'm out of ideas why it works for one workd and not for another. I will be more than happy if you would like to have a look with me to see what is going one. i'm always in discord id you want to ping me there palanolho#7943 :(

gsimon2 commented 3 years ago

Can you do me a favor and check that the Disable Dramatic Rolls for NPCs and GM setting is not enabled for your non-working world? That will prevent rolls that are not associated with player owned tokens from triggering effects. I think I can hop on discord tonight probably around 6 or so eastern time. I will ping and see if we can link up.

PalaNolho commented 3 years ago

yes, it's not selected :) I remembered this setting and it was the first thing I checked. I even selected it, saved then unselected it again and saved again just in case...

tonight probably around 6 or so eastern time

Sounds good, thanks!

PalaNolho commented 3 years ago

ok ... We found the problem :D which it seems it's intentional The sounds and confetti (if integrated) will only trigger for public roll.

I consider this bug closed then.