gsimon2 / hide-player-ui

Foundry Virtual Tabletop module for hiding player control ui.
2 stars 3 forks source link

Foregroud Issue #27

Closed antipop001 closed 1 year ago

antipop001 commented 1 year ago

Hello, We are playing in person with a TV in the table. So I am using "Hide Player UI" with an extra player user that has observer permissions to all the players characters. It is working great all except for one thing. When there is a foreground layer it won't uncover, even if a token is in the area that should be uncovered. Any suggestions?

gsimon2 commented 1 year ago

I am not exactly following. If you could attach a short video demonstrating the problem or give me steps to reproduce it, that would be greatly appreciated.

Either way, when I get time I will see if I can reproduce it locally and get a fix out.

antipop001 commented 1 year ago

Hello, Attaching two pics. One is a single player view. One is the Hide UI view. The Hide UI user has observer rights to all the tokens. But the foreground still obscures the view. Had to use a dropbox link, the files were two big.

Thank you Anish

https://www.dropbox.com/sh/gbsouchowuhesfq/AABAYgQm5wnu4FQDqpBNlkHwa?dl=0

On Sun, Jan 29, 2023 at 6:49 AM Glen Simon @.***> wrote:

I am not exactly following. If you could attach a short video demonstrating the problem or give me steps to reproduce it, that would be greatly appreciated.

Either way, when I get time I will see if I can reproduce it locally and get a fix out.

— Reply to this email directly, view it on GitHub https://github.com/gsimon2/hide-player-ui/issues/27#issuecomment-1407654876, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDENOLXGYYBJWF7FLG4JB3WUZROBANCNFSM6AAAAAAUKBH7WI . You are receiving this because you authored the thread.Message ID: @.***>

gsimon2 commented 1 year ago

Hey,

Thanks for the images. I am having trouble reproducing this bug. Below I have a test account set up with the chest set up on the foreground layer as an overhead tile (which is what appears is the roof is from your images).

We can debug further if you want.

What is your: System? Foundry version? Hidden player ui settings?z Any other relevant mods?

6B820C7C-6529-4FC6-81D1-1D038655C8CD

antipop001 commented 1 year ago

Hello, I have attached a settings file. Hiding all settings for a single user. The user is not an owner of any characters, just an observer for all. Is that an issue?

Thanks!

On Thu, Feb 9, 2023 at 7:08 PM Glen Simon @.***> wrote:

Hey,

Thanks for the images. I am having trouble reproducing this bug. Below I have a test account set up with the chest set up on the foreground layer as an overhead tile (which is what appears is the roof is from your images).

We can debug further if you want.

What is your: System? Foundry version? Hidden player ui settings?z Any other relevant mods?

[image: 6B820C7C-6529-4FC6-81D1-1D038655C8CD] https://user-images.githubusercontent.com/20954654/217973332-e1ddcee9-3151-4955-b885-0ebc24942ce6.GIF

— Reply to this email directly, view it on GitHub https://github.com/gsimon2/hide-player-ui/issues/27#issuecomment-1425039354, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDENON3TP5TPVE26QACDIDWWWIINANCNFSM6AAAAAAUKBH7WI . You are receiving this because you authored the thread.Message ID: @.***>

Core Version: 10.291

System: pf2e 4.7.2 (The PF2e System Developers)

Modules: NotYourTurn 2.0.0 (STB) _CodeMirror 5.58.3-fvtt5 (zeel, The League of Extraodinary FVTT Developers, Marijn Haverbeke) active-effect-manager-lib 0.1.24 (p4535992) advanced-macros 1.19.3 (mclemente, p4535992) alternative-rotation 2.2.0 (shem) ambientdoors 2.3.3 (EndlesNights) barbrawl 1.7.7 (Adrian Haberecht) colorsettings 2.9.1 (ardittristan#0001) combat-enhancements 1.2.1 (Asacolips) compendium-folders 2.5.6 (Erceron) df-manual-rolls 2.4.0 (flamewave000) df-qol 1.8.0 (flamewave000) df-scene-enhance 3.6.0 (flamewave000) df-settings-clarity 3.3.0 (flamewave000) dice-calculator 1.5.3 (Asacolips) dice-so-nice 4.6.5 (Simone, JDW) dragupload 2.2.2 (Cody Swendrowski @.***>) forien-copy-environment v2.1.6 (Blair McMillan, Forien) fxmaster 3.5.2 (Johannes Loher (ghost), Emmanuel Ruaud (U~man)) healthEstimate 29.5.10 (MClemente, Shylight) hide-player-ui 1.5.2 (Glen Simon) hlo-importer 0.10.1 (Zach Armstrong (SLATE)) illandril-token-tooltips 3.2.1 (Joe Spandrusyszyn (illandril)) initiative-double-click 1.6.1 (Matheus Clemente, KaKaRoTo) lib-wrapper 1.12.12.0 (Rui Pinheiro) mcc 1.4.0 (Arcanist, Michael Leahy (TyphonJS)) miskasmaps 1.4 () moonlight-maps-free 1.1.0 (Moonlight Maps) mountup 3.3.5 (Brunhine, p4535992) multilevel-tokens 1.6.0 (grandseiken) perfect-vision 4.1.16 (dev7355608) pf2-pdf-en-import 1.26 (Deidril) pf2e-animal-companions 5.5 (Tikael) pf2e-ap178-180-outlaws-of-alkenstar 1.0.4 (Paizo) pf2e-ap178-punks-in-a-powderkeg 1.2.3 (Paizo) pf2e-dorako-ui 1.11.9 (Dorako) pf2e-f-is-for-flatfooted 4.20.1 (DrentalBot) pf2e-mercenary-marketplace-vol1 2.0.6 () pf2e-modifiers-matter 1.5.3 (shemetz) pf2e-tokens-bestiaries 1.0.4 (Ian Hildebrandt, Viviane Charlier, Shane Martland) popout 2.10 (KaKaRoTo, Posnet) quick-insert 2.8.0 (Sunspots) scaleGrid 1.4.2 (ArcaneRoboBrain) settings-extender 1.2.1 (Azzurite#2004) smarttarget 0.9.7 (theripper93) socketlib 1.0.12 (Manuel Vögele) tidy-ui_game-settings 0.1.51 (sdenec) token-action-hud 3.0.19 (Larkinabout, Drental, ^ and stick) token-attacher 4.5.11 (KayelGee) token-auras 2.3 (Kim Mantas) token-health 0.6.0 () token-tooltip-alt 3.1.5 (bmarian) token-z 0.8.1 (theripper93) torch 2.4.0 (Deuce, Lupestro) vtta-tokenizer 3.10.1 (MrPrimate, Sebastian Will)

List generated with Forien's Copy Environment: https://github.com/League-of-Foundry-Developers/foundryvtt-forien-copy-environment

gsimon2 commented 1 year ago

The user is not an owner of any characters, just an observer for all

Yea, this is not related to hidden player UI then. I can repro this without any modules installed if the player doesn't have ownership permissions to the token. Just give the player account that is logged into the TV ownership permissions of all the PC tokens and it should work fine.