gsingers / slack-jira-plugin

A Slack plugin that watches channels for messages about JIRA and acts accordingly
MIT License
252 stars 83 forks source link

Update OAuth to support RSA-SHA1 #36

Open jacobweber opened 7 years ago

jacobweber commented 7 years ago

As far as I can tell, JIRA doesn't support HMAC-SHA1 for the OAuth signature method; it only supports RSA-SHA1. At least this is the case for some versions.

The included jira library doesn't support RSA-SHA1. Maybe it can be replaced with this one?

I was only able to get OAuth working using the latter library, although I had to change the API calls slightly.

I also was able to get it working by changing package.json to use this fork:

"jira": "ccannell/node-jira"

which has this fix. Then I added:

"signature_method": "RSA-SHA1"

to the oauth config.

gsingers commented 7 years ago

Can you put up a PR, @jacobweber ?