search

gskinnerTeam / flutter-universal-platform

A web-safe implementation of dart.io.Platforms. Helps avoid the "Unsupported operation: Platform._operatingSystem" runtime error.
MIT License
108 stars 29 forks source link

Kind of a bug: analysis_options includes pedantic but pubspec.yaml does not depend on padentic? #5

Closed emme1444 closed 3 years ago

emme1444 commented 3 years ago

Upon locally cloning and inspecting the repository, I found that the analysis_options.yaml file depends on pedantic's analysis_options.yaml however, there is no such dependency in the top-level pubspec.yaml.

My text editor (VSCode) gives me a warning about it not finding it.

Is this absence intentional? Or maybe I'm stupid?

If not, I can make a PR real quick, if you could give me some pointers. If that's okay?

Thanks for the package anyhow!

esDotDev commented 3 years ago

Definitely not intentional, a PR would be great! Please remove pedantic wherever it is referenced.

On Sun., Jan. 17, 2021, 10:48 a.m. Emil Walser, notifications@github.com wrote:

Upon locally cloning and inspecting the repository, I found that the analysis_options.yaml file depends on padentic's analysis_options.yaml however, there is no such dependency in the top-level pubspec.yaml.

My text editor (VSCode) gives me a warning about it not finding it.

Is this absence intentional? Or maybe I'm stupid?

If not, I can make a PR real quick, if you could give me some pointers. If that's okay?

Thanks for the package anyhow!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gskinnerTeam/flutter-universal-platform/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFT5TOD474EJSBJJJXCSN3S2MPIHANCNFSM4WGI4IDQ .

emme1444 commented 3 years ago

Okay good! There you go.