gskinnerTeam / flutter-wonderous-app

A showcase app for the Flutter SDK. Wonderous will educate and entertain as you uncover information about some of the most famous structures in the world.
MIT License
4.02k stars 947 forks source link

Font sizes on iOS seem off #165

Closed mit-mit closed 8 months ago

mit-mit commented 9 months ago

I created some screenshots of a wonder screen with the iOS font size setting screen pasted in on top. It looks like the font size in the app is generally too small compared to the setting?

IMG_0002

IMG_0004

mit-mit commented 9 months ago

cc @jmagman to get her input

jmagman commented 9 months ago

Looks pretty close? I don't have a preference, seems like a design choice with the custom font and not a bug since it did scale larger.

mit-mit commented 9 months ago

Here's a better comparison, where I also used a light background from the setting screen.

I can comfortable read the text from the settings screen, but it's very straining for me to read the wonderous text.

IMG_0007
esDotDev commented 9 months ago

Thanks for the report! It does seem like the body text here is noticeably smaller than what is shown as an example in the device settings. I verified this on Android as well.

We do downscale our font sizes a bit on smaller devices to help the UI fit better. Maybe we should exempt the body text to better align with user expectations?

Any thoughts @jaredbell?

jaredbell commented 9 months ago

@esDotDev Took a look into this across devices, platforms, etc. — I think the best option is to remove the concept of scaling down.

This was a safeguard for older, smaller devices but ultimately affects common/large sized ones as well as it's only looking at device pixel width.

Removing this brings the dynamic type scale back in line which is great for accessibility and user expectations.

We could retain the slight upscaling in place (1.15x-1.25x) as it tends to help fill out the screen a bit more on tablets and desktop/web with larger text/titles and more generous margins.

esDotDev commented 8 months ago

This has been addressed in v2.2.2 which should be available for download in test-flight.

@mit-mit The font size should be more like you expect now! Please let us know if this is not the case.

mit-mit commented 8 months ago

Font size looks great now, thanks!