search

gskinnerTeam / flutter_vignettes

A collection of fun Flutter experiments, created by gskinner, in partnership with Google.
https://flutter.gskinner.com
MIT License
4.58k stars 1k forks source link

Migrating to new flutter sdk #24

Closed SoroushBeigi closed 8 months ago

SoroushBeigi commented 8 months ago

I'm just fascinated with flutter_vignettes and gskinner's other flutter-related works, so I decided to try reading the source code. I realized that flutter_vignettes is written in old dart SDK, does not support null safety and used some deprecated classes like Overflow so I decided to refactor the "dark_ink_transition" project and "_shared" package as a start. it is now usable code in the last dart version (and any other version after null safety!). I hope you accept this PR and please let me know if there is anything wrong about it. I'm willing to refactor all of the vignettes to make everybody able to use these fascinating designs. Keep up the good work!

esDotDev commented 8 months ago

Thank's for the PR! This is good timing as we are looking to convert the codebase to the latest version of Flutter over the next couple of weeks. I'll try to review and land this today and then we can potentially divide and conquer on the remaining vignettes!

SoroushBeigi commented 8 months ago

I've read the reviews and will try to stick to them as a foundation. thank you