search

gsklee / ngStorage

localStorage and sessionStorage done right for AngularJS.
MIT License
2.33k stars 461 forks source link

hasFocus() for IE doesn't solve all problems #179

Open stackia opened 8 years ago

stackia commented 8 years ago

JS 'storage' event occurs to all windows in IE, but in other browsers it only occurs to the windows excluding source window. Currently ngStorage uses 'hasFocus' to ignore this event in source window, but it doesn't solve all problems. If window1 changes $localStorage.foo, window2 watches $localStorage.foo then change $localStorage.bar, it triggers a new 'storage' event, but it's not ignored by itself (instead, ignored by window1 because it's focused).

http://stackoverflow.com/questions/18265556/why-does-internet-explorer-fire-the-window-storage-event-on-the-window-that-st

Consider do some hacky to make it behave the same in all browsers?

egilkh commented 8 years ago

Alright, thanks for the report :)

Yes, we'll find some way to make this work. I've been swamped last weeks with work. But I'll get on this and all the other issues this week when things settle.

I'm not a fan of making hacks to let IE be correct, makes me think too much about the web ~2000. But if we end up having too, we will!