search

gslab-econ / gslab_python

Python tools for GSLab
MIT License
13 stars 11 forks source link

Pull request for #157: Missing import in matlab builder? #158

Closed arosenbe closed 6 years ago

arosenbe commented 6 years ago

@z-y-huang, can you PR my work for #157? (I know how much you like working with python builders.)

The bug was the missing import sys in build_matlab.py. I also took the opportunity to clear up some icky argument passing for matlab and stata.

z-y-huang commented 6 years ago

@arosenbe, yep!

arosenbe commented 6 years ago

Thanks @z-y-huang, can you look over my changes at https://github.com/gslab-econ/gslab_python/pull/158/commits/55a933895074d3a7e65a0adefb666364154f1aa6 too?

z-y-huang commented 6 years ago

Superb deleting skills @arosenbe!