search

gslab-econ / gslab_python

Python tools for GSLab
MIT License
13 stars 11 forks source link

Remove mmh3 dependency #167

Closed DavidRitzwoller closed 5 years ago

DavidRitzwoller commented 5 years ago

The new version of the Mac OS is incompatible with the python library mmh3. See comment thread here, featuring @ryanedmundkessler. Anyone with a new mac will be unable to install gslab python. We currently call mmh3 only once, here.

There is a pure python implementation of mmh3, pymmh3, that we've confirmed can be installed on the new mac OS. We should be able to simply replace mmh3 with pymmh3 and ensure that users with new Macs to able to install gslab python.

@gentzkow @jmshapir FYI

DavidRitzwoller commented 5 years ago

We've confirmed that the package can be installed subsequent to the change implemented here. PR at #168.