search

gslab-econ / gslab_r

5 stars 1 forks source link

SaveData() cannot take list/vector columns #34

Closed zhizhongpu closed 1 month ago

zhizhongpu commented 2 months ago

SaveData() runs into the following error when the input dt/df has list/vector columns:

Error: x must be an atomic vector or data.frames/data.tables
Execution halted

Here we either force that no list/vector is exported through SaveData() or we accommodate list/vector columns.

liaochris commented 2 months ago

We should force that no list/vector is exported through SaveData() in alignment with the python version.

zhizhongpu commented 2 months ago

We should force that no list/vector is exported through SaveData() in alignment with the python version.

@ShiqiYang2022 @Xingtong-Jiang @veli-m-andirin @rcalvo12 here and in https://github.com/gslab-econ/gslab_python/pull/188 we are to enforce no list/vector storage through SaveData R and Python. If you have any concerns or questions, please let us know. Thank you!

@liaochris if you don't see anything in a few days let's proceed with your proposal

liaochris commented 1 month ago

In this issue, we modified SaveData to only accept data with columns that are not of type list.