gsmainclusivetechlab / interop-test-platform

MIT License
6 stars 1 forks source link

iLP generation and validation #342

Closed brunosmm closed 3 years ago

brunosmm commented 3 years ago

Current the platofrm uses fixed ilp values which is working since most of times is simulators against simulators, altough once adding a real DFPS the ilp need to be proper generate by the simulators and validate in the messages that arrived in the platform.

Tasks:

Requirements:

https://docs.mojaloop.io/mojaloop-specification/documents/API%20Definition%20v1.0.html#4-interledger-protocol https://docs.mojaloop.io/mojaloop-specification/documents/API%20Definition%20v1.0.html#listing-12

Open Points:

Requires further investigation in how to implement it. Example of implementation from ttk: https://github.com/mojaloop/ml-testing-toolkit/blob/cbeff4a296c21f7fb0995526846a9fd8989b82be/src/lib/mocking/middleware-functions/ilpModel.js

cjol commented 3 years ago

As an implementation note, I think the best way to tackle this is to add a custom laravel validator function for checking incoming packets, and also a custom twig function so that we can generate outgoing packets in any context.

cjol commented 3 years ago

The javascript implementation is available here: https://github.com/mojaloop/sdk-standard-components/blob/master/src/lib/ilp/index.js

cjol commented 3 years ago

I've put together a demo PHP implementation which can be probably copied: https://gist.github.com/cjol/bef1d655a6b2d5ce2a57a243d4e06904