gsmainclusivetechlab / interop-test-platform

MIT License
6 stars 1 forks source link

Control Available Session Modes per Group #516

Open cjol opened 3 years ago

cjol commented 3 years ago

Currently, three environment variables limit which modes are available for selection when a new session is created: SESSION_TEST_AVAILABLE, SESSION_TEST_QUESTIONNAIRE_AVAILABLE and SESSION_COMPLIANCE_AVAILABLE.

It would be desirable to control this per-usergroup. A group should have a setting which controls which modes are available for users of that group. If a user is a member of multiple groups, the most permissive option applies (i.e. if one group has access to compliance, and another group has access to test mode, the user should have access to both).

Platform administrators will be able to change these settings on a group's administration page (in the same place as email filter is set).

cc @Viji-GSMA

cesdias commented 2 years ago

There is an error on the unit testing preveting the build of the docker image by CircleCi:

--

There was 1 failure:

1) Tests\Unit\Controllers\Admin\GroupControllerTest::testGroupControllerStore
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'http://localhost/admin/groups'
+'http://localhost'

/var/www/src/vendor/laravel/framework/src/Illuminate/Testing/TestResponse.php:388
/var/www/src/vendor/laravel/framework/src/Illuminate/Testing/TestResponse.php:275
/var/www/src/tests/Unit/Controllers/Admin/GroupControllerTest.php:20

ERRORS!
Tests: 50, Assertions: 79, Errors: 9, Failures: 1.

Generating code coverage report in Clover XML format ... done [00:01.969]

Exited with code exit status 2

CircleCI received exit code 2
cesdias commented 2 years ago

@yvoitenko Could you please check this error on the test? This is preventing the building and upload of the docker image to the repository.