gsmlg-dev / Flutter-Neumorphic

Refactored at https://github.com/gsmlg-dev/material-neumorphic
https://gsmlg-dev.github.io/Flutter-Neumorphic/
MIT License
8 stars 8 forks source link

Flutter 3.22 build failed on Android #3

Open bsz0206 opened 6 months ago

bsz0206 commented 6 months ago

Fails to compile on Flutter 3.22.0

../../AppData/Local/Pub/Cache/hosted/pub.dev/flutter_neumorphic_plus-3.3.0/lib/src/widget/app_bar.dart:185:14: Error: The getter 'headline5' isn't defined for the class 'TextTheme'.

feykro commented 6 months ago

Same problem here

bsz0206 commented 6 months ago

@feykro use the following until they fix it (my forked version):

flutter_neumorphic_plus: { git: { url: https://github.com/bsz0206/flutter_neumorphic_plus2.git } }

feykro commented 6 months ago

@bsz0206 Thanks, I'll try after I'm done with the rest of the issues in my project! I don't know if you plan on maintaining your fork and/or releasing it, but I think Neumorphism deserves a well-maintained package! In my opinion, it could use some polish and modernization, such as negative depth for text or surface tint for widgets.

gsmlg commented 6 months ago

I've refactored this project at https://github.com/gsmlg-dev/material-neumorphic. This package is not yet qualified enough for production use. If you want to use this package, it's recommended to clone it and include it in your project using Melos.

bsz0206 commented 4 months ago

@gsmlg Can we at least merge my pull request. It is only two lines in app_bar.dart and makes it compatible with the new flutter material. The current one cannot build for android.

It actually addresses to Analysis issues:

Pass static analysis 0/50 trigger folding of the section 0/50 points: code has no errors, warnings, lints, or formatting issues Found 93 issues. Showing the first 2:

ERROR: The getter 'headline5' isn't defined for the type 'TextTheme'. ERROR: The getter 'bodyText2' isn't defined for the type 'TextTheme'.

gsmlg commented 4 months ago

@gsmlg Can we at least merge my pull request. It is only two lines in app_bar.dart and makes it compatible with the new flutter material. The current one cannot build for android.

It actually addresses to Analysis issues:

Pass static analysis 0/50 trigger folding of the section 0/50 points: code has no errors, warnings, lints, or formatting issues Found 93 issues. Showing the first 2:

ERROR: The getter 'headline5' isn't defined for the type 'TextTheme'. ERROR: The getter 'bodyText2' isn't defined for the type 'TextTheme'.

Your pr has already been merged for a month, but foggot to publish to pub.dev. Now this package has been publish to pub.dev as 3.4.0