search

gsoft-inc / ansible-role-azure-devops-agent

An Ansible role that installs and configures a Linux machine to be used as an Azure DevOps build or deployment agent.
59 stars 72 forks source link

forcing task to run in check mode #13

Closed krknopp closed 4 years ago

krknopp commented 4 years ago

Adding this line allows the roles to finish in check mode.

krknopp commented 4 years ago

updating to libcurl4, so it doesn't uninstall curl on ubuntu 18.04

yohanb commented 4 years ago

Interesting! Didn't know check mode existed but it makes sense to get the service status. Thanks for the contribution!

egrier commented 4 years ago

Would adding a tag not be more efficient? It's my understanding that using the check mode only applies to running --check or -C when running the entire playbook. If you just wanted to only check the status of the service you could just add a tag of status so only that task will run.

krknopp commented 4 years ago

Not for my use case. I want the entire playbook to be able to run in --check mode for nightly "checks". I'm not looking just to check the status of the service.

yohanb commented 4 years ago

since this only applies to a specific use case (running a playbook in checkmode), I don't see a problem to leave the check_mode attribute. May I merge the PR @krknopp ?

yohanb commented 4 years ago

@krknopp bump

krknopp commented 4 years ago

Yes, please do. Thank you!