gsoft-inc / sg-orbit

The design system for ShareGate web apps.
https://orbit.sharegate.design
Apache License 2.0
101 stars 37 forks source link

🚀 Migrate Circle CI to Github Actions #1097

Closed alexasselin008 closed 1 year ago

alexasselin008 commented 1 year ago

Description

Orbit currently uses CircleCI to build the application on every PR, and run chromatic tests on every PR.

With the current informations, it appears CircleCI brings nothing that Github Actions couldn't do, so we should consider migrating to github actions, to reduce the number of third party involved.

This recommandation comes following this incident https://circleci.com/blog/january-4-2023-security-alert/

at the moment in circle ci we have 2 jobs:

Those jobs are ran:

I'm not sure why running Nightly is necessary, considering that it runs even if no changes were detected, i think

alexasselin008 commented 1 year ago

https://github.com/gsoft-inc/sg-orbit/pull/1137