gsoft-inc / sg-orbit

The design system for ShareGate web apps.
https://orbit.sharegate.design
Apache License 2.0
101 stars 37 forks source link

Allow eslint rule "testing-library/no-container" to run on unit tests #1098

Closed alexasselin008 closed 1 year ago

alexasselin008 commented 1 year ago

By using container methods like .querySelector you may lose a lot of the confidence that the user can really interact with your UI. Also, the test becomes harder to read, and it will break more frequently.

related to https://github.com/gsoft-inc/sg-orbit/issues/1099

netlify[bot] commented 1 year ago

Deploy Preview for sg-storybook ready!

Name Link
Latest commit edead3c73b672154860b75bdaee1aa1fb7ba8421
Latest deploy log https://app.netlify.com/sites/sg-storybook/deploys/63c6eaba16988d000802aa0f
Deploy Preview https://deploy-preview-1098--sg-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for sg-orbit ready!

Name Link
Latest commit edead3c73b672154860b75bdaee1aa1fb7ba8421
Latest deploy log https://app.netlify.com/sites/sg-orbit/deploys/63c6eabad747be0008f7d45d
Deploy Preview https://deploy-preview-1098--sg-orbit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.