gsoft-inc / sg-orbit

The design system for ShareGate web apps.
https://orbit.sharegate.design
Apache License 2.0
101 stars 37 forks source link

❗ Activate missing testling-library and jest eslint rules #1099

Closed alexasselin008 closed 1 year ago

alexasselin008 commented 1 year ago

Description

Some eslint rules had to be disabled because they were causing warnings in our codebase. It would be nice to fix the issues:

            "jest/no-commented-out-tests": "off", // TODO remove this when we fix all commented out tests
            "testing-library/no-unnecessary-act": "off", // multiple errors, should be fixed in another PR. 515 errors
            "testing-library/prefer-screen-queries": "off", // multiple errors, should be fixed in another PR. 1343 errors
            "testing-library/prefer-find-by": "off", // multiple errors, should be fixed in another PR. 135 errors
            "testing-library/no-node-access": "off", // multiple errors, should be fixed in another PR. 37 errors
            "testing-library/prefer-presence-queries": "off" // multiple errors, should be fixed in another PR. 21 errors

Checklist: