Convert CSF Stories to CSF 3 + TypeScript

gsoft-inc / sg-orbit

The design system for ShareGate web apps.

https://orbit.sharegate.design

Apache License 2.0

101 stars 37 forks source link

Closed alexasselin008 closed 1 year ago

alexasselin008 commented 1 year ago

chroma.jsx that were in the CSF were:

Even if the stories are in the CSF3 format, that all specify a render function, which could be optimised by:

if the render function only forward props to compnents, it could be remove and replaced with args
if the render function is similar to another test, spread the other test in the story instead of re-writing it entirely

Mutiple test have been modified because they were using property that aren't available anymore.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	d4addaff433257d8bd34247cad5c0dd73266b22c
Latest deploy log	https://app.netlify.com/sites/sg-orbit/deploys/63d3fa71cff2620008192675
Deploy Preview	https://deploy-preview-1129--sg-orbit.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	d4addaff433257d8bd34247cad5c0dd73266b22c
Latest deploy log	https://app.netlify.com/sites/sg-storybook/deploys/63d3fa71b6ab12000819813b
Deploy Preview	https://deploy-preview-1129--sg-storybook.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	f330262d6c975475ddff135caef9434a2d935cdb
Latest deploy log	https://app.netlify.com/sites/sg-orbit/deploys/63d412dfaca5730009903833
Deploy Preview	https://deploy-preview-1129--sg-orbit.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	f330262d6c975475ddff135caef9434a2d935cdb
Latest deploy log	https://app.netlify.com/sites/sg-storybook/deploys/63d412df68e32a000870b2b8
Deploy Preview	https://deploy-preview-1129--sg-storybook.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

alexasselin008 commented 1 year ago

New Stories:

Grid: 40 stories were added in Grid, since the viewport chromatic setting were never set up properly
GroupField: button group -> Renamed story (but not the name) because of a typo, no other changes
Tooltip - Renamed stories (but not the name) because of a typo, no other changes